search

eclipse-platform / eclipse.platform.releng.aggregator

Aggregated repository for Eclipse Java IDE
https://www.eclipse.org/eclipse/
Eclipse Public License 2.0
27 stars 67 forks source link

Update verifyFreezePeriod.yml to consider milestone promotions not as error #2170

Closed vogella closed 2 weeks ago

vogella commented 2 weeks ago

From https://github.com/eclipse-platform/eclipse.platform.ui/pull/1967#issuecomment-2210725473

Milestones don't have freezes but there is still the "promotion" day in the calendar (so everyone can see when it is) and the script checking it https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/42b625b2b0e971e1147761a7473e55170a3f5504/.github/workflows/verifyFreezePeriod.yml#L22 doesn't distinguish between M, RC and R promotion thus we end up with this freezes during M promotion days. It would be nice if someone enhances the script to not complain for milestone promotions.

vogella commented 2 weeks ago

@sratz and @HannesWell you worked on this script before. Could you update it so that milestone promotions are not reported as freezes?

vogella commented 2 weeks ago

Thanks @sratz and @HannesWell