search

eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

Add a comment to the PR from Jenkins when build is finished #11

Closed jonahgraham closed 2 years ago

jonahgraham commented 2 years ago

Post a comment to PR when build is complete.

Use the github-pipeline plug-in to do so. Documented: https://github.com/jenkinsci/pipeline-github-plugin

jonahgraham commented 2 years ago

This is an experiment to figure out if we can use pipeline-github-plugin to achieve https://github.com/eclipse-platform/eclipse.platform.resources/pull/4#issuecomment-1079420463

At the moment it looks like pipeline-github-plugin is not enabled for the platform CI instance

eclipse-releng-bot commented 2 years ago

This PR is highly illogical. Eventually it will not be

jonahgraham commented 2 years ago

This PR is highly illogical. Eventually it will not be

@iloveeclipse Woohoo! We can now add comments from the GItHub pipeline (see last comment from the bot). So what should we add?

iloveeclipse commented 2 years ago

@jonahgraham : I would add build result, or if that is complicated, at least a note that Jenkins is done.

merks commented 2 years ago

This is cool!

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-11/14/

jonahgraham commented 2 years ago

I have added a simple comment (see https://github.com/eclipse-platform/eclipse.platform.resources/pull/11#issuecomment-1084924837) at the end of the build.

I now leave it for others to enhance as they see fit.

Because of GitHub actions vs Jenkins PR build I don't want to invest more time on writing better Jenkins pipelines if we are just going to abandon it in favour of GitHub actions.

iloveeclipse commented 2 years ago

I think we should first have all the transition to github settled before we would change the main build server/config. For now I see github actions as a useful addon to quickly provide some feedback.

If everything is moved and stabilized a bit, one could check if github actions can fully replace jenkins.

akurtakov commented 2 years ago

FYI, We can not fully move to GH actions as only Jenkins have write access to download.eclipse.org. I understand this doesn't matter for verification builds but putting it here so everyone is aware of this limitation.

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-11/16/

jukzi commented 2 years ago

that message is like spam because i get an email after each build. Together with the feature that any push does triggger builds of all open PRs i get spammed by email. see https://github.com/eclipse-platform/eclipse.platform.resources/pull/4 for example.

laeubi commented 2 years ago

that message is like spam because i get an email after each build.

Yep, same here, that's really annoying. If it would be a message that he build failed it probably would be useful, but thats something that should be send to the author/reviewers of a PR only....