search

eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

Try pushing the initializePreferenceLookupOrder() furhter down... #125

Closed laeubi closed 2 years ago

laeubi commented 2 years ago

Lets see what CI verification thinks about it..

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-125/1/

iloveeclipse commented 2 years ago

Wouldn't this mean, all project related preferences access would silently return workspace preferences?

laeubi commented 2 years ago

At least in the init phase of the workspace, actually as we are inside the same plugin it might even be better to not use the preference service but use ProjectPreferences and pass appropriate project reference there... Also the ProjectPreferences are not really interested at the Workspace itself but the WorkspaceRoot, but I don't know if it is save to access the root without the workspace open...

laeubi commented 2 years ago

I think I found a more clean solution for this now...