search

eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

Add getLineSeparator(IResource resource) API #158

Closed jukzi closed 2 years ago

jukzi commented 2 years ago

To avoid copy&paste or divergent behavior in other plug-ins.

for https://github.com/eclipse-platform/eclipse.platform.debug/pull/28

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-158/1/

mickaelistria commented 2 years ago

Please allow more time to review API addition in the core classes. APIs should not be rushed in. Why not IResource.getLineSeparator() ? or even IFile.getLineSeparator() as it doesn't make much sense on a container?

mickaelistria commented 2 years ago

See #159 to improve API.

mickaelistria commented 2 years ago

See #159 to improve API.