search

eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

fix NPE in toString() debugging only #22

Closed jukzi closed 2 years ago

jukzi commented 2 years ago

Change-Id: Ica27521fa7813fa60994eb2399bcf9b0ae096482

jukzi commented 2 years ago

what is that "continuous-integration/jenkins/branch" ? looks like its stuck "Pending — This commit is being built" after 3h

vogella commented 2 years ago

what is that "continuous-integration/jenkins/branch" ? looks like its stuck "Pending — This commit is being built" after 3h

No idea. @mickaelistria can you help?

mickaelistria commented 2 years ago

this branch is pushed against eclipse-platform upstream repo, not against your fork. That is per se one cause of the problem.

jukzi commented 2 years ago

this branch is pushed against eclipse-platform upstream repo, not against your fork. That is per se one cause of the problem.

is that a problem of my commit? can i rebase it? or a configuration thing?

mickaelistria commented 2 years ago

is that a problem of my commit? can i rebase it? or a configuration thing?

Yes, the problem is that you pushed your topic branch to the wrong repo. Your work should always go first to your fork. It can be a configuration of the default push repo on your end, being set to eclipse-platform one instead of your fork.

In the meantime, for that particular PR, let's not make things complicated: you can ignore the pending job and only care about the pr-merge one; and merge as soon as you have enough confidence nothing new is broken. Then later we can delete the jukzi202203311152 branch from this repo.

merks commented 2 years ago

FYI, you should do it like this:

https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#recommended-workflow

jukzi commented 2 years ago

Yes, the problem is that you pushed your topic branch to the wrong repo. Your work should always go first to your fork. It can be a configuration of the default push repo on your end, being set to eclipse-platform one instead of your fork.

what a fork? I am confused. i think it's OK for committers to not fork but create&delete branch on repo. that should not result i error.

mickaelistria commented 2 years ago

i think it's OK for committers to not fork but create&delete branch on repo

It's not so OK. It's not forbidden but it also cause issues on the repo and the project (multiplication of personal branches, bigger reflog resulting in bigger clones, CI processing more stuff as if it were official...). The link shared by @merks in a previous comment describes the best way of doing thing, which prevents from such issue.