eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

Adding tests to Github build action #24

Closed vogella closed 2 years ago

vogella commented 2 years ago

Using the setup from https://github.com/faktorips/faktorips.base/blob/dc5748886e13eb98e15d5ee802c9e23902b3cf23/.github/workflows/maven.yml#L46

Fix #23

vogella commented 2 years ago

Even more important that updating the label, we should also use Maven lib caching to reduce the build time / downloads.

laeubi commented 2 years ago

Even more important that updating the label, we should also use Maven lib caching to reduce the build time / downloads.

You most probably want to include product files (if any) in the hash computation

key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ hashFiles('**/*.product') }}

vogella commented 2 years ago

Even more important that updating the label, we should also use Maven lib caching to reduce the build time / downloads.

key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ hashFiles('**/*.product') }}

AFAICS resources does not have product files includes.

vogella commented 2 years ago

Btw. @laeubi I'm not sure if the caching will actually be correct here as the pom files refer to a remote pom which is mainly defining the buld.

laeubi commented 2 years ago

At least it will cache the basics but maybe not be as efficient as if all changes are detected.