search

eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

Bug 578618 - fixed attributes retrieval by equal (not identical) keys #5

Closed iloveeclipse closed 2 years ago

jukzi commented 2 years ago

the Reason to use IdentityHashMap was to have the small memory overhead you requested. probably there is just a String.intern() missing somewhere.

iloveeclipse commented 2 years ago

the Reason to use IdentityHashMap was to have the small memory overhead you requested.

As long as it would work, yes. But the code breaks functionality.

probably there is just a String.intern() missing somewhere.

No, you can't control what is used as keys in other maps or do String.intern() on every get() csll. PDE code compares two maps, so IdentityHashMap can't be used.