search

eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

RefreshManager.manageAutoRefresh calls ResourcesPlugin.getWorkspace #98

Closed laeubi closed 2 years ago

laeubi commented 2 years ago

Fix https://github.com/eclipse-platform/eclipse.platform.resources/issues/97 Blocks: https://github.com/eclipse-platform/eclipse.platform.resources/pull/71

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-98/2/

laeubi commented 2 years ago

I also don't get why introducing the new class is necessary for the issue described in commit message. So either the code has to be reduced to focus on fixing the issue it's about, or the commit message has to be enhanced to describe why more changes seem necessary. I would prefer the former.

Seems it is not necessary I have reworked that now.

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-98/4/

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-98/5/

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-98/6/

mickaelistria commented 2 years ago

I think most of @iloveeclipse 's concerns were covered with latest patches, and I'm optimist about the current changes being correct. So to not delay it further and to remove some duties from @iloveeclipse 's backlog, I'm going to merge it.