eclipse-platform / eclipse.platform.resources

Eclipse Public License 2.0
3 stars 18 forks source link

use java.nio.file.Files.copy for LocalFile copy #99

Closed jukzi closed 2 years ago

jukzi commented 2 years ago

I sampled a full JDT junit test and it's obvious that most time of the build is literally wasted by creating a unnecessary history of projects setting. A minor improvement would be to at least use a appropriate system call for file copy instead of transferring streams. image

eclipse-releng-bot commented 2 years ago

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-99/1/

jukzi commented 2 years ago

-2 On Windows nio.Files.copy takes ~2x the time of current implementation transfering Streams. Should be other way around. I do not get why. less SecurityOptions copied? this sucks.

iloveeclipse commented 2 years ago

Thanks Jörg for validation.