search

eclipse-platform / eclipse.platform.swt

Eclipse SWT
https://www.eclipse.org/swt/
Eclipse Public License 2.0
101 stars 123 forks source link

Fix usage of re-scaled fonts in Control:setFont for windows #1272

Closed akoch-yatta closed 3 weeks ago

akoch-yatta commented 3 weeks ago

In Control::setFont the passed font and not the font from the SWTFontProvider is used. This has only an effect when the ScaledFontRegistry is used and a font is passed, that does not match the current zoom of the control.

Contributes to https://github.com/eclipse-platform/eclipse.platform.swt/issues/62 and https://github.com/eclipse-platform/eclipse.platform.swt/issues/127

github-actions[bot] commented 3 weeks ago

Test Results

   434 files  +16     434 suites  +16   7m 7s :stopwatch: -55s  4 125 tests + 4   4 117 :white_check_mark: + 4   8 :zzz: ±0  0 :x: ±0  16 317 runs  + 4  16 225 :white_check_mark: + 4  92 :zzz: ±0  0 :x: ±0 

Results for commit 9d166d71. ± Comparison against base commit 7e1f4a02.

:recycle: This comment has been updated with latest results.

akoch-yatta commented 3 weeks ago

Thank you for this PR and working on the tests. I just have some minor comments regarding some methods and also one question: are the tests really running? I saw this in the raw logs:

2024-06-07T14:36:53.0664757Z [INFO] Running org.eclipse.swt.widgets.ControlWin32Tests
2024-06-07T14:36:53.0792349Z [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s -- in org.eclipse.swt.widgets.ControlWin32Tests

Can you please check that?

The tests are running (at least in the latest build), but currently the tests seems to be configured to only run for win32.x86_64, but not win32.aarch64, so they appear twice in the logs, once executed and once not executed.