eclipse-platform / eclipse.platform.swt

Eclipse SWT
https://www.eclipse.org/swt/
Eclipse Public License 2.0
112 stars 135 forks source link

Scaling combo text according to zoom level #1284

Closed ShahzaibIbrahim closed 3 months ago

ShahzaibIbrahim commented 3 months ago

Registering the comboDpiChange handler and applying change manually to text, image and arrow

Contributes to https://github.com/eclipse-platform/eclipse.platform.swt/issues/62 and https://github.com/eclipse-platform/eclipse.platform.swt/issues/127

HOW TO TEST (Windows only!)

EXPECTED BEHAVIOUR

Combo list, text and arrow should be properly scaled.

github-actions[bot] commented 3 months ago

Test Results

   470 files  ±0     470 suites  ±0   7m 33s :stopwatch: -43s  4 135 tests ±0   4 127 :white_check_mark: ±0   8 :zzz: ±0  0 :x: ±0  16 336 runs  ±0  16 244 :white_check_mark: ±0  92 :zzz: ±0  0 :x: ±0 

Results for commit a4979ae4. ± Comparison against base commit 5cdf3315.

:recycle: This comment has been updated with latest results.

ShahzaibIbrahim commented 3 months ago

Can you please look into that?

@fedejeanne I have fixed the issue. Could you please check it again in both cases? (100 -> 200) and (200 ->100)

HeikoKlare commented 3 months ago

@fedejeanne please check if you still request changes or may drop your change request