eclipse-platform / eclipse.platform.swt

Eclipse SWT
https://www.eclipse.org/swt/
Eclipse Public License 2.0
101 stars 123 forks source link

Adding refreshCheckSize() to refresh the check size **Windows 11 Only** #1314

Closed ShahzaibIbrahim closed 4 hours ago

ShahzaibIbrahim commented 5 days ago

In the Windows -> Preference -> General dialog, when moved from higher zoom level (200) to lower zoom level (100), we found a visible gap between the checkboxes whether it was created horizontally or vertically.

image

Solution: Refresh the checkWidth and checkHeight Size whenever there is a dpi change or when button is created. Factor is calculated by identifying the zoom change e.g. 100 -> 200 should be scaled down to half (currentZoom / primaryZoom)

HOW TO TEST (Windows 11 Only)

EXPECTED BEHAVIOUR

Spacing should be fixed w.r.t. zoom level

Contributes to #62 and #127:

github-actions[bot] commented 5 days ago

Test Results

   470 files  ±0     470 suites  ±0   7m 48s :stopwatch: +16s  4 135 tests ±0   4 127 :white_check_mark: ±0   8 :zzz: ±0  0 :x: ±0  16 336 runs  ±0  16 244 :white_check_mark: ±0  92 :zzz: ±0  0 :x: ±0 

Results for commit 8a8d8872. ± Comparison against base commit e02dd674.

:recycle: This comment has been updated with latest results.