search

eclipse-platform / eclipse.platform.swt

Eclipse SWT
https://www.eclipse.org/swt/
Eclipse Public License 2.0
117 stars 135 forks source link

Support for changing the color of table separator lines #386

Closed gayanper closed 2 years ago

gayanper commented 2 years ago

image

As you can see in the above image, when the table lines are configured not to be visible the intensity of the column header separators are increased. It would be nice to add support to configure this color.

In addition if the same color property can be used to control the table lines that would be a +1 as well since then the lines can be dimmed enough just to be a guide in dark themes.

OS: Windows 10 Eclipse Version: 2022-12 (4.26) Build id: I20220913-1800

SyntevoAlex commented 2 years ago

Please use Display.setData(Display.TABLE_HEADER_LINE_COLOR_KEY, new Color(...)). Note that OS.setTheme(true) already does that, along with a number of other Dark Theme customizations.

gayanper commented 2 years ago

Please use Display.setData(Display.TABLE_HEADER_LINE_COLOR_KEY, new Color(...)). Note that OS.setTheme(true) already does that, along with a number of other Dark Theme customizations.

Thanks will try this out. Could we make this as part of css theming ?

SyntevoAlex commented 2 years ago

To my understanding, CSS theming is part of Eclipse, not SWT. In Eclipse, you should simply select Dark theme and it will apply these settings automatically.

gayanper commented 2 years ago

To my understanding, CSS theming is part of Eclipse, not SWT. In Eclipse, you should simply select Dark theme and it will apply these settings automatically.

Sure will raise this in platform ui which manage the theming.