search

eclipse-platform / eclipse.platform.swt

Eclipse SWT
https://www.eclipse.org/swt/
Eclipse Public License 2.0
117 stars 135 forks source link

[regression in 4.24..4.25] DND of trim bar elements (perspective switch, launch group...) don't work properly on Wayland #589

Open mickaelistria opened 1 year ago

mickaelistria commented 1 year ago

Using I20230313-0110 on latest Fedora , I cannot drag and drop the trim bar elements to move them in other parts of the IDE. I tried to 2022-12 and I cannot do it as well.

I'm pretty sure that was possible not that long ago. I'll try older releases of Eclipse SDK, but I also suspect it can be an issue in OS events supports changed and the dragndrop not properly received by the trimbar. cc @mbooth101

iloveeclipse commented 1 year ago

@mickaelistria : I assume you are using Wayland. On RHEL 7.9 / X11 everything works fine for me, with latest master and with 4.27 release too.

iloveeclipse commented 1 year ago

Note: there was recently https://github.com/eclipse-platform/eclipse.platform.swt/pull/576 that was supposed to fix some DnD issues on Wayland, may be that caused regression here. @SyntevoAlex : FYI.

mickaelistria commented 1 year ago

Thanks @iloveeclipse ; I ran the same IDE in Xephyr (so using x11 instead of Wayland) and I could drag and drop trimbars; so definitely a Wayland issue.

mbooth101 commented 1 year ago

Note: there was recently #576 that was supposed to fix some DnD issues on Wayland, may be that caused regression here. @SyntevoAlex : FYI.

As @mickaelistria says, it is a problem also in 2022-12, so it seems unlikely that PR #576 caused the problem :-)

It's well known that Wayland doesn't let applications set the position of their top-level windows. Are these little draggable guys top-level windows?

trim-drag.webm

If they are top-level windows, this probably never worked at all on Wayland.

SyntevoAlex commented 1 year ago

Works for me in 2022-06 and doesn't work in 2022-12. So my recent commit is not guilty.

mickaelistria commented 1 year ago

I confirm what @SyntevoAlex mentions, this feature is working fine, even on Wayland, in Eclipse 4.24 and was lost in 4.25. Some regression took place.

akurtakov commented 1 year ago

@mickaelistria I use DnD on Wayland and it works but there is a small "catch" - make sure that your drag operation is starts with small mouse move up otherwise it doesn't get detected on my machine.

mickaelistria commented 1 year ago

@akurtakov I couldn't make it work. Note that I don't have issue with DND in general, it's really just the trimbar stuff that seems stuck.

mickaelistria commented 1 year ago

@akurtakov I succeeded (after many attemps) to do something with the trick you recommend and confirm it can do the job; but the overall issue is still here

mickaelistria commented 1 year ago

I'm wondering whether this one could be related to #177 and overall issue about some GTK3 method returning incorrect coordinates with Wayland.

manoda0 commented 5 months ago

Works for me in 2022-06 and doesn't work in 2022-12. So my recent commit is not guilty.

I confirm what @SyntevoAlex mentions, this feature is working fine, even on Wayland, in Eclipse 4.24 and was lost in 4.25. Some regression took place.

I tested in 2022-06, 2022-09 and 2024-03. Eclipse version 2022-06 works with Wayland. Versions 2022-09 and 2024-03 do not.

acarstoiu commented 3 months ago

In case anyone needed a confirmation, it still reproduces in Eclipse 4.32 (java.vendor.version=Temurin-21.0.3+9) running on GTK+ 3.24.41 and Wayland 1.22.