eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Bump o.e.jface.text version to 3.22 #114

Closed mickaelistria closed 1 year ago

mickaelistria commented 1 year ago

Previous change on LinkedModeUI.doExit actually added some API and should have triggered a version bump (but wasn't detected by API Tools).

iloveeclipse commented 1 year ago

@mickaelistria : do you want to proceed for 4.26 RC1 here? If yes, please add API filter for manifest warning that bumping is not necessary because of no changes found, something like

diff --git a/org.eclipse.jface.text/.settings/.api_filters b/org.eclipse.jface.text/.settings/.api_filters
index 172f43b..a604ea4 100644
--- a/org.eclipse.jface.text/.settings/.api_filters
+++ b/org.eclipse.jface.text/.settings/.api_filters
@@ -2,2 +2,10 @@
 <component id="org.eclipse.jface.text" version="2">
+    <resource path="META-INF/MANIFEST.MF">
+        <filter comment="See https://github.com/eclipse-platform/eclipse.platform.text/pull/114" id="926941240">
+            <message_arguments>
+                <message_argument value="3.22.0"/>
+                <message_argument value="3.21.0"/>
+            </message_arguments>
+        </filter>
+    </resource>
     <resource path="src/org/eclipse/jface/text/link/LinkedModeUI.java" type="org.eclipse.jface.text.link.LinkedModeUI$IExitPolicy">
mickaelistria commented 1 year ago

do you want to proceed for 4.26 RC1 here?

Yes, I think it's best. I'll try what you suggest.

iloveeclipse commented 1 year ago

Actually we must bump the version for 4.26, so would be good to do it in RC1.

mickaelistria commented 1 year ago

@iloveeclipse I interpreted your last comment as a positive review so this fix fulfills requirements to get into RC1

iloveeclipse commented 1 year ago

@iloveeclipse I interpreted your last comment as a positive review so this fix fulfills requirements to get into RC1

Please don't forget to update API filter as proposed, to avoid API warning.

mickaelistria commented 1 year ago

I don't see the API warning locally. Do you? I believe some recent fixes in API Tools have happened on that aspect.

iloveeclipse commented 1 year ago

I was using latest SDK build today while reviewing this patch. I saw API warning on manifest that bumping minor segment is nkt necessary. That's in accordance with API tooling "not seeing" the actual issue.

Btw, have you reported that to PDE? Looks lile adding default methods on inner classes isn't covered yet.

iloveeclipse commented 1 year ago

Still the warning shown in RC1: "The minor version should be the same for version 3.22.0, since no new APIs have been added since version 3.21.0"