search

eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

#122 #124

Closed AlexOnisa closed 1 year ago

iloveeclipse commented 1 year ago

Please click on "Details" of the error and sign ECA: image

mickaelistria commented 1 year ago

And actually, there are other issues with this whole API: the annotation shouldn't hold the position, as this position can change. The annotation model has all the smartness to get position for an annotation; so ideally, we'd just get rid of getPosition() and use the annotation model to get the position; this would most likely behave better overall. Further patches to consolidate the implementation would be welcome ;)

mickaelistria commented 1 year ago

Thanks for this fix!

mickaelistria commented 1 year ago

See https://github.com/eclipse-platform/eclipse.platform.text/pull/125