eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Minimap can cause NPE #69 #134

Closed GeraldMit closed 1 year ago

GeraldMit commented 1 year ago

fix Minimap can cause NPE #69

iloveeclipse commented 1 year ago

@GeraldMit : thanks for the patch.

So for now:

GeraldMit commented 1 year ago

@GeraldMit : thanks for the patch.

So for now:

  • create local branch on top of origin master branch
  • cherry pick your changes from your master on the new branch
  • squash all your commits to one providing appropriate commit message
  • push to your fork in github and create new PR.

Unfortunately, no access to a development environment that I can run git/EGit/VSCode on at the moment, and GitHub web doesn't have cherrypicking support. Will have to wait a few days.

GeraldMit commented 1 year ago

will open new pull request