eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Merge repo with https://github.com/eclipse-platform/eclipse.platform.text #167

Closed vogella closed 1 year ago

vogella commented 1 year ago

To simplify our Github repo structure we should merge this repo with one of our bigger once.

I sugest to target https://github.com/eclipse-platform/eclipse.platform

Ok for you? @mickaelistria @akurtakov @laeubi

akurtakov commented 1 year ago

Please either fix the failing test or disable it if not easily fixable so platform repo stay clean building.

akurtakov commented 1 year ago

https://github.com/eclipse-platform/eclipse.platform.text/pull/162 is the one to look at as it tries to unify platform.text build to be same as platform one.

iloveeclipse commented 1 year ago

I believe platform.text should be rather part of platform.ui, not platform.

mickaelistria commented 1 year ago

I believe platform.text should be rather part of platform.ui, not platform.

+1, I now remember we discussed it some time ago; and if we're to keep eclipse.platform.ui for a few more months; then it's better to move eclipse.platform.text into it.

vogella commented 1 year ago

162 is the one to look at as it tries to unify platform.text build to be same as platform one.

Done by disabling the failing test. @laeubi might have a solution to enable it again with another PR

laeubi commented 1 year ago

@vogella I think we can proceed here before M1?

laeubi commented 1 year ago

@vogella do you want to initiate the merge here for 2023-09-M1?

merks commented 1 year ago

@laeubi

Thanks so much for doing this! 🏅

I've updated/fixed the setups accordingly; I let the existing working sets for platform.ui "consume" the bundles and features merged in from platform.text.

laeubi commented 1 year ago

@merks many thanks to keeping the setup up-to-date :+1: