Fix ClassCastException in TextSearchVisitor.TextSearchJob

eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Closed jjohnstn closed 1 year ago

jjohnstn commented 1 year ago

TextSearchVisitor.TextSearchJob.processFile() has a catch for FileCharSequenceProvider.FileCharSequenceException and tries to rethrow the exception cause. In the case where the cause is an IOException, throw the original FileCharSequenceException which is a RuntimeException
discovered by https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/436

jjohnstn commented 1 year ago

@akurtakov Please review.

jjohnstn commented 1 year ago

@merks @mickaelistria Can this be merged? It is needed for a user to report the actual failure seen in a search.

jjohnstn commented 1 year ago

Thanks @merks