search

eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Remove AnnotationRulerColumn code added for bug 531952 #178

Closed iloveeclipse closed 1 year ago

iloveeclipse commented 1 year ago

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=531952 for original issue.

The code (text change listener) that was added to AnnotationRulerColumn to fix bug 531952 can be simply commented out without any visible regression.

Let's remove this code, it adds unneeded complexity & is inconsistent with the rest of the text listeners code that is supposed to be used from UI thread only.

Fixes https://github.com/eclipse-platform/eclipse.platform.text/issues/177

iloveeclipse commented 1 year ago

@angelozerr : Angelo, as you have originally reported https://bugs.eclipse.org/bugs/show_bug.cgi?id=531952, could you please check if that works in your environment / with your code too?

At least on Linux / latest master state I don't see any regressions like described in your original bug.

iloveeclipse commented 1 year ago

@angelozerr , @mickaelistria : ping.

angelozerr commented 1 year ago

Sorry @iloveeclipse it was a long time that I created the issue,but if I remembered I spend a lof of time to this problem.

Thanks for the merge.