eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Should code-mining be in italic? #194

Closed mickaelistria closed 1 year ago

mickaelistria commented 1 year ago

In big pieces of code with many codeminings (parameter names, markers message, some actions...) visible, it's hard to differentiate codeminings from actual code. I suggest we make them italic by default, similarly to theater stage instructions.

szarnekow commented 1 year ago

Could you please provide a screenshot to illustrate the problem?

mickaelistria commented 1 year ago

Here is an example of what things can look like in current state: Screenshot from 2023-05-11 20-26-44 and what I suggest it could look like (with italic and slightly smaller font) Screenshot from 2023-05-11 20-54-02

Note that the proper place that controls the font in this case is AbstractCodeMining.draw(...)

iloveeclipse commented 1 year ago

Looks better with italics.

mickaelistria commented 1 year ago

Let's target it for 4.29.