search

eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Prevent multiple "Press F2 for focus" in Generic Editor #195

Closed mickaelistria closed 1 year ago

mickaelistria commented 1 year ago

Fixes https://github.com/redhat-developer/eclipseide-jdtls/issues/42

iloveeclipse commented 1 year ago

Mickael, neither the commit nor pr no issue explain the problem or solution. No test is added to show the problem / fix. The change is definitely not trivial. This is not OK to push something like this, especially for experienced contributors.

mickaelistria commented 1 year ago

neither the commit nor pr no issue explain the problem or solution.

The first line of commit message describes the issue. As the describing the solution, it's true I didn't added notes about it; I though that combination of issue title + code was simple enough. Maybe I was wrong.

szarnekow commented 1 year ago

Can you please answer https://github.com/eclipse-platform/eclipse.platform.text/pull/195#discussion_r1185127187 too, @mickaelistria