Closed mickaelistria closed 1 year ago
Mickael, neither the commit nor pr no issue explain the problem or solution. No test is added to show the problem / fix. The change is definitely not trivial. This is not OK to push something like this, especially for experienced contributors.
neither the commit nor pr no issue explain the problem or solution.
The first line of commit message describes the issue. As the describing the solution, it's true I didn't added notes about it; I though that combination of issue title + code was simple enough. Maybe I was wrong.
Can you please answer https://github.com/eclipse-platform/eclipse.platform.text/pull/195#discussion_r1185127187 too, @mickaelistria
Fixes https://github.com/redhat-developer/eclipseide-jdtls/issues/42