search

eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Use less aggressive defaults #214

Closed rubenporras closed 1 year ago

rubenporras commented 1 year ago

Both the JDT and VSCode do not trigger auto completion on each alphanumeric character by default. They only do it on trigger characters and only with a delay of 10 milliseconds.

This PR change the configuration of the Generic Editor to have the same defaults

rubenporras commented 1 year ago

I do not know if this default would make other people happy and would remove the need to have user/integration configuration options, but it would definitely for us.

I guess such a change cannot go after RC1, even if we would agree that it is a better default, but if it can go, it would be very good for us.

mickaelistria commented 1 year ago

I think a small delay makes sense, we can maybe even push to 20ms as someone who types that fast is really typing "automatically" and most likely not interested in potential alternatives to what they're willing to type. However, I personally like the fact that we have autocomplete on every char and miss it a lot when I use JDT or VSCode. I'd prefer it to remain turned on by default.

rubenporras commented 1 year ago

I have updated the PR to only adapt the activation delay. I can also use 20 if you really prefer it, or 10 as in VSCode, I would not mind either.

mickaelistria commented 1 year ago

Can you please add a commit that bumps version by +0.0.100?

rubenporras commented 1 year ago

I have bumped the version number

mickaelistria commented 1 year ago

Thank you!