Search while you type... #78

eclipse-platform / eclipse.platform.text

8 stars 45 forks source link

Search while you type... #78 #81

Closed jukzi closed 1 year ago

jukzi commented 2 years ago

Adds a search filter to search result View after first search. Press ENTER to get into the fine grained search Dialog.

Providers have to implement IResearchQuery

some multithreading hardening of the search which pop up under that heavy load.

mickaelistria commented 2 years ago

I'm worried this proposal is very intrustive in the search API for something that seems more like a UI functionily mostly. I'll get back to the ticket to discuss possible less intrusive alternatives and maybe looser coupling.

jukzi commented 2 years ago

I'm worried this proposal is very intrustive in the search API for something that seems more like a UI functionily mostly. I'll get back to the ticket to discuss possible less intrusive alternatives and maybe looser coupling.

I don't get that comment. the API is only extended and totally optional. you can't get cool feature without API.

mickaelistria commented 2 years ago

Enabling this feature would require to adopt new API; I wish we can find a solution to eclipse-platform/eclipse.platform.ui#878 without new API.

vogella commented 2 years ago

I personally would love the functionality in the IDE. Thanks @jukzi for working on this. Once master opens I plan also to comment on the code (I did not yet look at it).

laeubi commented 1 year ago

This repository was merged with https://github.com/eclipse-platform/eclipse.platform.ui if your pull-request is still relevant please rebase the code and push it to the new repository.