search

eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
81 stars 187 forks source link

XMI-Editor: not adapted to theming #1154

Open Wittmaxi opened 1 year ago

Wittmaxi commented 1 year ago

Description

The XMI-Editor is not colored according to the theming. grafik

Reproducing

With these settings: grafik

Open a raw XMI-Editor

Expected behaviour

As this is just "a normal text-editor", I expect it to look like the normal text-editors I write Java in.

System Information

Eclipse SDK

Version: 2023-12 (4.30) Build id: I20230913-1800

HeikoKlare commented 1 year ago

The behavior is reproducible and I agree that one would expect this editor to have the same appearance as any other text editor.

However, this editor is not based on the general text editor but comes from e4 tooling for the underlying EMF models. The tab with the XMI editor is attached here:

https://github.com/eclipse-platform/eclipse.platform.ui/blob/fe7afe87df6cb76b347d0a438225c9b60c76af12/tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/ModelEditor.java#L551-L558

So if someone wants to look into this issue, that place may be a starting point.