search

eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
81 stars 188 forks source link

Tooltips of Tool items do not not show updated key bindings once updated from preferences #1466

Open umairsair opened 10 months ago

umairsair commented 10 months ago

Steps

  1. Start fresh workspace.
  2. Go to Windows > Preferences > General > Keys.
  3. Update the key binding of "Redo". image
  4. Apply and Close
  5. Hover over Redo tool item and it'll still show old key binding in tooltip. image
lathapatil commented 10 months ago

ToolTip is getting updated once the redo icon changes the state from disabled to enabled and vice versa.

umairsair commented 10 months ago

ToolTip is getting updated once the redo icon changes the state from disabled to enabled and vice versa.

Yes. Or when clicked if tool item is already enabled.

Dinesh0723 commented 8 months ago

I have tested in the latest Eclipse SDK version: 2024-03 (4.31) with build ID: I20240225-1800, and it is working fine. Please refer to the attached video,

https://github.com/eclipse-platform/eclipse.platform.ui/assets/130960675/f03725c2-02f5-4f51-9f72-004be6c559ce

umairsair commented 8 months ago

It would have been good if you also show the tooltip before changing the binding.

Dinesh0723 commented 8 months ago

It would have been good if you also show the tooltip before changing the binding.

Please refer the attached video,

https://github.com/eclipse-platform/eclipse.platform.ui/assets/130960675/fa66f927-2b5c-4594-9ef4-47562224b36e

umairsair commented 8 months ago

Can you please check on linux host. I quickly tried on linux with same build and issue is reproducible there.

Dinesh0723 commented 8 months ago

@umairsair, Looks like an SWT issue. When I check out the latest SWT source in the SDK, the problem doesn't occur. However, when I close the checked-out SWT source projects from Eclipse SDK (Version: 2024-03 (4.31), Build id: I20240226-1800), the issue reappears.

@SyntevoAlex, @Phillipus, As a newcomer to SWT, I'm curious about the potential root cause of this. Have you faced this kind of issues in SWT?

Phillipus commented 8 months ago

@SyntevoAlex, @Phillipus, As a newcomer to SWT, I'm curious about the potential root cause of this. Have you faced this kind of issues in SWT?

I didn't see this problem in our RCP app. I see it sometimes in Eclipse 4.30 but not 4.31

Dinesh0723 commented 7 months ago

The issue is reproducible only in Eclipse version 4.31 but not in version 4.32. I have tested in the latest Eclipse SDK version: 2024-06 (4.32), and the problem does not occur in both Windows and Linux environments.