eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
81 stars 188 forks source link

[Generic Editor] Add a Refactorings menu to the Generic Editor to allow command contributions #1785

Open ylussaud opened 7 months ago

ylussaud commented 7 months ago

Let's make sure issue is not already fixed in latest builds first.

Suggestion

I made a pull request to the LSP4E project and we think it would be better to move the Refactorings menu to the Generic Editor. This would allow anyone extending the Generic Editor to contribute refactoring commands in the same menu.

Community

If you think it's a good idea I can provide a pull request.

mickaelistria commented 7 months ago

+1, it's definitely a good idea. As generic editor is about code edition, it seems normal to expect that the editor provides a refactoring menu directly.