Compare-View: Cannot click to open folders

eclipse-platform / eclipse.platform.ui

Eclipse Platform

https://projects.eclipse.org/projects/eclipse.platform

Eclipse Public License 2.0

77 stars 160 forks source link

Compare-View: Cannot click to open folders #1838

Closed Wittmaxi closed 3 weeks ago

Wittmaxi commented 4 months ago

Let's make sure issue is not already fixed in latest builds first.

[x] I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Steps to reproduce

When double-clicking on a folder, the folder doesn't expand/collapse. Instead, I need to use the "drop-down"-arrow. I expected: the folder to open like in other views:

But got: nothing happened:

Tested under this environment:

Operating System Windows Eclipse version Build id: I20240416-0300

Community

[x] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

DenisUngemach commented 1 month ago

Hello,

i have checked the code. It seems that the double click action has never been implemented in the structure compare view.

In the DiffTreeViewer in line 283 a mouse listener on tree which checks on the double click action and expands if possible should solve this.

eclipse.platform team\bundles\org.eclipse.compare\compare\org\eclipse\compare\structuremergeviewer\DiffTreeViewer.java

I will add a Pull Request in time.

Best regards, Denis

DenisUngemach commented 1 month ago

There is also a double click handler somewhere, which changes the compare editor "perspective" on the double clicked element.

It is also the question whether a combination of the currently working double click feature and the expand actions is desired.

DenisUngemach commented 4 weeks ago

Also in the project explorer double click can mean dependent on the element different things. Double click on a folder expands the folder and doulel click on a file opens the file.

So doing the same for the compare view is valid.

@BeckerWdf What is your opinion.

DenisUngemach commented 3 weeks ago

@BeckerWdf Hi Matthias, can you check the PR?

It works, but i don't know whether this position in the code is absolutly right to use.

BeckerWdf commented 3 weeks ago

this is implemented with https://github.com/eclipse-platform/eclipse.platform/pull/1493