Vertical Scrolling not handled correctly in StickyScrollControl

eclipse-platform / eclipse.platform.ui

Eclipse Platform

https://projects.eclipse.org/projects/eclipse.platform

Eclipse Public License 2.0

79 stars 168 forks source link

Vertical Scrolling not handled correctly in StickyScrollControl #1966

Open BeckerWdf opened 3 months ago

BeckerWdf commented 3 months ago

Let's make sure issue is not already fixed in latest builds first.

[x] I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

This issue relates to https://github.com/eclipse-platform/eclipse.platform.ui/pull/1894

Steps to reproduce

I tried

Scrolled vertically with the scroll bar / the mouse wheel

I expected: That sticky lines scroll in the same way as the lines in the editor

But got:

https://github.com/eclipse-platform/eclipse.platform.ui/assets/28338612/20eca9aa-fb7d-44f5-99b5-286aaa5c7955

Tested under this environment:

OS & version: macOS

Community

[x] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

Christopher-Hermann commented 3 months ago

I think horizontal scrolling (right/left) is meant. On other IDEs this feature can be enabled via a setting.

The default is that the sticky lines do not scroll horizontal, as it is currently in the Eclipse implementation:

https://github.com/eclipse-platform/eclipse.platform.ui/assets/79514265/984c631a-c92a-485c-a003-00b073a9d6fd

With the feature turned on, it can become quite cluttered:

https://github.com/eclipse-platform/eclipse.platform.ui/assets/79514265/67079928-bcb4-4668-b550-1092e62f8959

I think it depends on the preferences of the user. So either we decide for one of the options, or we do provide a setting for this as well. But I'm not sure if adding more options to the settings is a good idea. Let's gather some feedback here.

BeckerWdf commented 3 months ago

I think horizontal scrolling (right/left) is meant.

Yes I mean left / right...

BeckerWdf commented 3 months ago

So either we decide for one of the options, or we do provide a setting for this as well. But I'm not sure if adding more options to the settings is a good idea. Let's gather some feedback here.

I would also try to not add yet another setting. I see you point. Having it unscrolled has it's use case if you are on a very long line in the editor but the sticky lines are rather short. On the other hand if it's the sticky lines are also long having them scrolled might be benefitial. But I don't have a strong option on that. It would also be ok for me to keep the current implementation as it is.