eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
81 stars 188 forks source link

Accessibility: Navigating through Controls with Tab does autoscroll to the Viewer with Focus #1973

Open GuilhermeSaraiva96 opened 5 months ago

GuilhermeSaraiva96 commented 5 months ago

Let's make sure issue is not already fixed in latest builds first.

Steps to reproduce

From a fresh installation and clean workspace: I created a Plugin Project.

I tried

  1. Navigated to the Extensions Tab within the MANIFEST.
  2. Added enough random extensions so that when making the window smaller, the Tree Viewer would have a scroll bar.
  3. Set the Selection the last extension in the viewer.
  4. Scroll up so that the selection is not visible anymore.
  5. Navigating through each of the controls is possible using Tab or Shift+Tab. Navigate to the Filter Text Control above the Viewer (Shift+Tab for me). The Text Control should have gotten Focus.
  6. Make the window as small as possible till you can't see the viewer anymore.
  7. Click Tab

I expected: Focus is returned to the Viewer Control. There is autoscrolling so that the element in focus remains always in view. Since there are 2 scrollbars in this example (from the editor and from the viewer), both must be autoscrolled so that the focus control is in view, but also the selection within the control.

But got: Focus does get returned to the Viewer Control, but this is not visible until I scroll down to reveal the viewer and indeed it has focus.

Video: https://sap-my.sharepoint.com/:v:/p/guilherme_saraiva/EaHGXdtkUt5DktiwDpSvrx8B6iRTKbVw_OYc_lxLMhp8Tw?e=FjNILy&nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJTdHJlYW1XZWJBcHAiLCJyZWZlcnJhbFZpZXciOiJTaGFyZURpYWxvZy1MaW5rIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXcifX0%3D

Why this is important

At SAP we have several use cases in which the Editor has a Tree Viewer with Selection Detail at the bottom, and one needs to scroll down to see it (simulated by making the window smaller above). Navigating with the Tab Key improves usability and contributes to an inclusive design, thus why it would be important that this feature works flawlessly.

If you have any tips on where the related code could be found, I would very much appreciate it as a starting point for me as well

Community

BeckerWdf commented 5 months ago

This happens und Windows an macOS, doesn't it?

wurzka commented 5 months ago

Yes, this happens under Windows and macOS