Umbrella Issue: find/replace overlay issues

Wittmaxi commented 3 weeks ago

This Issue documents my views on priority for the issues of the find/replace overlay. High issues are issues which are blocking a possible release

high

medium

low

unclear

[ ] https://github.com/eclipse-platform/eclipse.platform.ui/issues/1911

Wittmaxi commented 3 weeks ago

@HeikoKlare did I miss anything we discussed in our meeting?

HeikoKlare commented 3 weeks ago

Priorities look sound. Just the following issues were missing (I have added them to the initial post with the mentioned priorities):

1907 (high)
1914 (medium)
1998 (medium)

arsenalzp commented 3 weeks ago

Hello, Any of those issues are for newcomers (good-first-issue)?

Wittmaxi commented 3 weeks ago

@arsenalzp Hi, if you are looking to get into them I can give you some pointers, just ask in the corresponding issues :)

These should be (relatively) straight-forward to do: https://github.com/eclipse-platform/eclipse.platform.ui/issues/1991 https://github.com/eclipse-platform/eclipse.platform.ui/issues/2012

This one might is a bit harder, but maybe you can help me by creating a prototype for how such a resize-mechanism could look like? https://github.com/eclipse-platform/eclipse.platform.ui/issues/1996

Some issues are already actively being fixed, others are more involved. I can of course help you get into them too, just ask 😀

Please add me to the reviewers of your PRs so that I can roughly see what is happening in the Overlay!

arsenalzp commented 3 weeks ago

@arsenalzp Hi, if you are looking to get into them I can give you some pointers, just ask in the corresponding issues :)

These should be (relatively) straight-forward to do: #1991 #2012

This one might is a bit harder, but maybe you can help me by creating a prototype for how such a resize-mechanism could look like? #1996

Some issues are already actively being fixed, others are more involved. I can of course help you get into them too, just ask 😀

Please add me to the reviewers of your PRs so that I can roughly see what is happening in the Overlay!

Thank you for detail explanation! Let me explore the project and its architecture a little bit :)

HeikoKlare commented 3 weeks ago

I have just added #2033 (high prio) and #2034 (low prio) to the list.

lukeu commented 3 weeks ago

Early adopter feedback - maybe consider adding #1813 to the list?

I almost logged an issue but realised the prior issue existed. I'd seen it occasionally with ALT+click to make multiple cursors (which I don't do often). I think the Find overlay will make this much easier to encounter, however.

Say I need to do a multple replace. Often I'll copy the "new" text to the clipboard, select the old text and then...

Maybe I'll even just use ["Find Again", "Paste"] keys a few times (very fast, no find UI needed), or
If there's more than a few hits, I'll...
- Press Ctrl+F (the "old" text is entered into the Find Overlay - nice)
- Press Ctrl+Enter (a multi-selection is made - nice)
- Whack ESC, Paste

The last step just seems more quick & natural to me than [expand the overlay, paste it there, replace, close it]

The problem is: if Find found 100 hits - this bug inserts 10,000 copies (!)

HeikoKlare commented 2 weeks ago

Thank you for your early adopter feedback, @lukeu! It is great to see you testing new functionality and then also giving feedback on it. That's very valuable!

I agree that the reported bug is quite annoying. Personally, I did not use the described workflow so far but rely on the "replace all" functionality of the find/replace dialog/overlay, but I see how beneficial the workflow can be (and when you can use it, it should of course work as expected anyway). Since it's not a bug introduced by the new UI, I also do not see an urgent need of having it fixed in the context of the find/replace overlay and would consider it with lower priority than other issues that might reduce acceptance and/or adoption of the new UI. Still, as you mentioned that the issue becomes more "obvious" with the new UI (https://github.com/eclipse-platform/eclipse.platform.ui/issues/1813#issuecomment-2211226306), I would propose to simply put it on this issue's list (even though it might be priority "low" in the context of this issue).

Wittmaxi commented 2 weeks ago

I am adding https://github.com/eclipse-platform/eclipse.platform.ui/issues/2053 with high priority

HeikoKlare commented 2 weeks ago

Also add #2046 (with high prio)?

Wittmaxi commented 2 weeks ago

@HeikoKlare Yes! Done!

Wittmaxi commented 2 weeks ago

Added https://github.com/eclipse-platform/eclipse.platform.ui/issues/2055 with medium priority Added https://github.com/eclipse-platform/eclipse.platform.ui/issues/2054 with high priority

Wittmaxi commented 2 weeks ago

Added https://github.com/eclipse-platform/eclipse.platform.ui/issues/2059 with high priority @HeikoKlare is this related to your recent changes to the positioning of the overlay?

HeikoKlare commented 2 weeks ago

Added:

2060 (prio low)
2075 (prio high)

HeikoKlare commented 1 week ago

Added with medium priority (feel free to change if you see a different prio fitting):

2080

Wittmaxi commented 1 week ago

Medium Prio: https://github.com/eclipse-platform/eclipse.platform.ui/issues/2099

Low Prio: https://github.com/eclipse-platform/eclipse.platform.ui/issues/2100

Wittmaxi commented 1 week ago

Low prio: https://github.com/eclipse-platform/eclipse.platform.ui/issues/2105

eclipse-platform / eclipse.platform.ui