search

eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
78 stars 162 forks source link

modern light theme: editor right bar to bright #2201

Open jukzi opened 3 weeks ago

jukzi commented 3 weeks ago

Only the editor content should have white background, but now also the bar right to the scroll bar has white contrast. image old scheme had had it grey: image

BeckerWdf commented 3 weeks ago

see https://github.com/eclipse-platform/eclipse.platform.ui/pull/2144 for this. Maybe you can help @mvm-sap with your knowledge to fix the remaining issues in that PR.

jukzi commented 3 weeks ago

Maybe you can help @mvm-sap with your knowledge to fix the remaining issues in that PR.

Sorry i have no knowledge about how to use themes at all. All i remember is that i did consider the css enginge broken when i looked into it years ago as it did not consider subclasses to match super classes and would suggest to fix that before working with it. Also i would expect that the Layout Spy (shift-ctrl-alt-f9) shows which css classes an element does adhere to. But i can't see helpful information there. Maybe improve that tool first? image

jukzi commented 2 weeks ago

with css spy fixed (https://github.com/eclipse-pde/eclipse.pde/issues/1381) one can see this in the css spy (old light theme): image and with preview light theme: image

jukzi commented 2 weeks ago

i.e. this CSS entry did the coloring:

CTabFolder Canvas {
    background-color: #F8F8F8;
}

https://github.com/eclipse-platform/eclipse.platform.ui/blob/b06fb4736ef968ed4b7a143084dad7f86b1bfd86/bundles/org.eclipse.ui.themes/css/e4_default_win.css#L74

Adding that to e4_preview_win.css solves this problem - but i don't know what else it will color too.