Open jukzi opened 3 weeks ago
see https://github.com/eclipse-platform/eclipse.platform.ui/pull/2144 for this. Maybe you can help @mvm-sap with your knowledge to fix the remaining issues in that PR.
Maybe you can help @mvm-sap with your knowledge to fix the remaining issues in that PR.
Sorry i have no knowledge about how to use themes at all. All i remember is that i did consider the css enginge broken when i looked into it years ago as it did not consider subclasses to match super classes and would suggest to fix that before working with it. Also i would expect that the Layout Spy (shift-ctrl-alt-f9) shows which css classes an element does adhere to. But i can't see helpful information there. Maybe improve that tool first?
with css spy fixed (https://github.com/eclipse-pde/eclipse.pde/issues/1381) one can see this in the css spy (old light theme):
and with preview light theme:
i.e. this CSS entry did the coloring:
CTabFolder Canvas {
background-color: #F8F8F8;
}
Adding that to e4_preview_win.css
solves this problem - but i don't know what else it will color too.
Only the editor content should have white background, but now also the bar right to the scroll bar has white contrast.
old scheme had had it grey:
![image](https://github.com/user-attachments/assets/1b6774f0-2609-4f2c-a885-d2f7c3a1eb16)