eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
81 stars 189 forks source link

Workspace Search: Don't load binary files unless needed #2216

Open Wittmaxi opened 3 months ago

Wittmaxi commented 3 months ago

When performing a workspace Search (Ctrl + H) and excluding search in binary files, we currently still load all files in order to determine which files to look through.

Ideally, we would only look into files which we know to be nonbinary, for example by discriminating based on file-extension. I am not sure what an ideal solution would look like.

Issue stems from a discussion in https://github.com/eclipse-platform/eclipse.platform.ui/issues/2180

Wittmaxi commented 3 months ago

@christianstaib