search

eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
79 stars 171 forks source link

Implement ActivitySupport filtering for DynamicContributionContributionItem #2217

Open raghucssit opened 1 month ago

raghucssit commented 1 month ago

org.eclipse.e4.ui.workbench.renderers.swt.DynamicContributionContributionItem is a Contribution Item contributed by E4 Application model. This does not support Activity Support filtering like org.eclipse.ui.internal.PluginActionContributionItem.

An example Window-->Spies Menu Item is visible even if we disable Plug-in Development Activity in Window-->Preferences-->General-->Capabilities-->Development-->Plug-in Development. Note that, Activity Support workin fine for other E3 components like views, wizards etc. spies-menu-item

I tried to implement this support at org.eclipse.e4.ui.workbench.renderers.swt.DynamicContributionContributionItem but org.ecliplse.ui.workbench is not accessible here to access PlatformUI.getWorkbench().getActivitySupport() due to cyclic dependency. I need some suggestion on how to achieve this.

iloveeclipse commented 1 day ago

Note: the very same views are also not filtered in Ctrl+3 dialog if PDE activity is disabled, so there is more work to be done to fully hide them.

raghucssit commented 1 day ago

Note: the very same views are also not filtered in Ctrl+3 dialog if PDE activity is disabled, so there is more work to be done to fully hide them.

Sad. It is not filtering in Quick Access. I will check. image