search

eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
81 stars 185 forks source link

UI Freeze in Help>About and in Installation Details #2283

Open nlisker opened 1 month ago

nlisker commented 1 month ago

Opening Help>About and also Installation Details from there causes a UI freeze the first time these dialogs are opened.

ui freeze log.log

I think that the events that happened up to 11:22:46 (inclusive) are for Help>About, and at 11:22:57 are for Installation Details.

I assume that the freeze is caused by reading the features and plugins. This can be done in a background thread and populated when the results are accumulated, or even update the lists continuously as the results are updated (more fancy). A temporary stand-in message "fetching...", or some progress indicator could be displayed meanwhile.

The log is for 4.33, but it has been happening on previous versions too.

jukzi commented 1 month ago

will you work on this?

nlisker commented 1 month ago

I'm not familiar enough with the platform unfortunately. Just reporting.

deepika-u commented 1 month ago

@nlisker - I am unable to reproduce this. are you observing this in the base SDK, or do you have a number of features installed? if so, how many? I shall try to mimic that by adding that many features.

nlisker commented 1 month ago

I have features installed: image image

Is this enough info?

merks commented 1 month ago

This is unlikely to be a priority work item for anyone. You'll still have to wait, the UI just won't say it's frozen which is nicer, but ask yourself, who wants to work for a whole day to fix this problem when there are literally hundreds of issues open for things that one does all the time...

nlisker commented 1 month ago

You'll still have to wait

Not if all I want is to see the version/build ID in the About dialog, which is what a lot of people open About dialogs for.

but ask yourself, who wants to work for a whole day to fix this problem when there are literally hundreds of issues open for things that one does all the time...

Are you suggesting not to report low priority issues when there are hundreds of others in the queue? Otherwise what's the point of this comment? To answer the question of who wants to work on this: it's open source, anyone who wants to contribute. Especially as their first issue to learn the ropes.

Honestly, I contribute to a project that has more open issues than this one and we never ask a user who submitted a low-priority issue "ask yourself, who wants to work for a whole day to fix this problem?". We mark it as low priority and let whoever wants to do it submit a PR.

jukzi commented 1 month ago

We welcome every report. The feedback that nothing may happen just shows the respect to the reporter to give a status what can be expected.

merks commented 1 month ago

No offense intended! Of course freezing is bad design and there are no "bad" problem reports. I'm just trying to set expectations. As far as I see, there is not much triage done here so what's 360 issues this month might be 700 issue in 6 months and eventually there are so many issues we start to talk about auto-closing them because it's all unmanageable.

The unfortunate fact of life around here is that the issues that get the most attention are the ones to which people contribute fixes. We're happy to help enable you in that regard. But if you have other priorities that's perfectly understandable too.