Selection does not consider line-spacing

albertmink commented 4 hours ago

Let's make sure issue is not already fixed in latest builds first.

[x] I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Steps to reproduce

From a fresh installation and clean workspace:

Set line spacing > 0

I tried

select a character or a word

I expected: that selection marker extend over the line-spacing

But got: The selected character/word is displayed as if line-spacing were 0

Here is some relevant log output

From <workspace>/.metadata/.log

<relevant log output>

Tested under this environment:

OS & version: ...
Eclipse IDE/Platform version (as shown in Help > About): ...
...Anything else that can be useful...

Community

[x] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

jukzi commented 4 hours ago

Did you read that? Do you plan to contribute a PR that does the job?

BeckerWdf commented 4 hours ago

Did you read that? Do you plan to contribute a PR that does the job?

I don't think that his sentence relates to this issue. The extra linespacing setting has some issues - so I would say it's simply a bug. Pls. have a look at https://github.com/eclipse-platform/eclipse.platform.swt/pull/1329. There we did a fix for the selection in such cases. How is your case different?

albertmink commented 3 hours ago

@BeckerWdf let's consider three cases: ( I just wanted to play with this feature 🥲 )

(1) see initial post.

(2) selecting multi line (partial)

(3) selecting multi line (entire)

Let's say only (3) looks good.

eclipse-platform / eclipse.platform.ui