Find/replace overlay: does not resize when hiding Replace row

eclipse-platform / eclipse.platform.ui

Eclipse Platform

https://projects.eclipse.org/projects/eclipse.platform

Eclipse Public License 2.0

81 stars 182 forks source link

Find/replace overlay: does not resize when hiding Replace row #2372

Open ronso0 opened 1 week ago

ronso0 commented 1 week ago

open Find/replace overlay (Replace was hidden previously)
hit Ctr+R/CMD+R -> Replace row is shown, overlay expands vertically
hit Ctr+R/CMD+R -> Replace row is hidden, overlay does not shrink to original height

Though, I think I see it quickly shrink and expand again. Maybe just a timing issue, like internally showReplace is still true while a resize is triggered?

Eclipse-find-replace-resize

I didn't find this in #2021 Noticed with Ubuntu Studio 20.04.5 + xfce4.14 CDT 2024-09 (4.33.0.20240905-0613) (can't efford to test nightlies or build myself, sorry)

jukzi commented 1 week ago

which OS?

ronso0 commented 1 week ago

sorry.. Ubuntu Studio 20.04.5

HeikoKlare commented 5 days ago

Unfortunately, I cannot reproduce this issue on Ubuntu 22.04.02. Might be that the shown behavior also changed/improved with #2254, but for me it did not even appear before that PR has been merged. Would be good to retest it on your system with that change. Maybe you can try out the 2024-12 M2 once it is released?

As you mentioned, this may be a timing issue, as size update and layouting are performed asynchronously (on Linux). Can you give some more details on when this happens: does it always occur when closing the replace bar or only in specific situations?