search

eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
81 stars 190 forks source link

Find/Replace Overlay: Compare Editor #2498

Open jukzi opened 3 weeks ago

jukzi commented 3 weeks ago

ctrl+f in Compare editor still opens modal search dialog. That feels inconsistent image

HeikoKlare commented 3 weeks ago

This is actually not a bug but a known limitation: the overlay is currently only implemented for StatusTextEditor. This limitations comes from how the positioning happens, which requires specific information that is not generically available for all kinds of find targets, so some conceptual extension needs to be implemented for that.

Wittmaxi commented 3 weeks ago

In fact, the same happens in the Console. As Heiko has pointed out, this is by design. I am planning on +eventually+ coming around to at least implementing a concept that could help other vendors use the Find/Replace Overlay themselves.