[Dark Theme] Checkbox created with toolkit on dialog has wrong background

eclipse-platform / eclipse.platform.ui

Eclipse Platform

https://projects.eclipse.org/projects/eclipse.platform

Eclipse Public License 2.0

81 stars 184 forks source link

[Dark Theme] Checkbox created with toolkit on dialog has wrong background #416

Open marcushoepfner opened 2 years ago

marcushoepfner commented 2 years ago

A button with SWT.CHECK gets a wrong background color (light grey instead of dark grey) under the following conditions:

created on a dialog
toolkit used (FormToolkit.createButton)
darktheme

In an editor this does not happen.

Does happen on Mac. Not on Windows.

akurtakov commented 2 years ago

Can you share the snippet to reproduce?

marcushoepfner commented 2 years ago

sure. background.test_1.0.0.202210171431.zip

(It's actually a jar, but github does not support. You might need to rename back to .jar)

marcushoepfner commented 2 years ago

I have started analyzing this:

FormToolkit calls adapt() when creating the checkbox; a background color is set
afterwards the css engine overwrites this background color via Control.setBackground(Color color) with null
this leads to the light grey eventually

Compared to e.g. a label created with toolkit

FormToolkit calls adapt() when creating the label; a background color is set
afterwards the css engine overwrites this background color via Control.setBackground(Color color) with a concrete color

Is just the color in css missing?

marcushoepfner commented 2 years ago

Does someone has a hint how to fix this? If so, I can take over and try.

akurtakov commented 2 years ago

Can you share the code for this jar so it can be used for debugging?

marcushoepfner commented 2 years ago

Oh damn. I forgot. Thanks for bearing with me. Here it is, same disclaimer: rename from zip to jar background.test.source_1.0.0.202210191250.zip

marcushoepfner commented 10 months ago

Hi, any progress on this one?

akurtakov commented 10 months ago

Unfortunately not many people look into MacOS specific issues (@Phillipus only lately) . In my opinion this could be SWT bug but it could be css styling issue too. In order to get this issue moving people with interest (and access) in MacOS have to step up but you can further help by trying to reduce the snippet to pure SWT snippet one .

Phillipus commented 10 months ago

not sure whether it happens on Windows.

OK on Windows:

reduce the snippet to pure SWT snippet one .

Not sure if that's possible as it depends on dark theme and Theming framework.

@marcushoepfner Perhaps you might investigate the dark *.css files in the theme plug-in to see if any change required there?