eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
78 stars 166 forks source link

'link with editor' does not work in 2023-03 when using the Debug perspective (works in Java perspective) #814

Open elecharny opened 1 year ago

elecharny commented 1 year ago

It was not working either for 2022-06, but working fine in 2020-12.

Typically, if I 'explode' the project to show all the Java files (which is basically impossible with 24 projects, hundreds of modules and thousands directories...), I can link with editor, but if the projects or directories are collapsed, then 'link with editor does not work anymore.

That was working at some point in the past 2 or 3 years ago?), the 'double arrow' was opening the project and directories to highlight the file in the editor, it's not the case anymore.

This is a major issue, it makes Eclipse IDE almost irrelevant when working with many projects and a lot of files (I'm using it for Apache Directory Server,n which has 50 modules and hundreds of packages for thousands of files, plus Apache MINA in 3 versions, plus 10 other projects in a professional env)

mickaelistria commented 1 year ago

Are you using Package Explorer or Project Explorer? I cannot reproduce it locally, using Project Explorer, on Linux, with Version: 2023-09 (4.29) / Build id: I20230608-1800

elecharny commented 1 year ago

Hi Mickael!

I'm using Project Explorer, on a Mac OS machine (2019, so not M1/M2):

*** Date: vendredi 9 juin 2023 à 22:42:52 heure d’été d’Europe centrale

*** Platform Details:

** System properties: applicationXMI=org.eclipse.ui.workbench/LegacyIDE.e4xmi ds.delayed.keepInstances=true ds.delayed.keepInstances.default=true eclipse.application=org.eclipse.ui.ide.workbench eclipse.buildId=4.27.0.20230309-1200 eclipse.commands=-os macosx -ws cocoa -arch x86_64 -showsplash /Users/elecharny/.p2/pool/plugins/org.eclipse.epp.package.common_4.27.0.20230309-1200/splash.bmp -launcher /Users/elecharny/rcp-2022-12/Eclipse.app/Contents/MacOS/eclipse -name Eclipse --launcher.library /Users/elecharny/.p2/pool/plugins/org.eclipse.equinox.launcher.cocoa.macosx.x86_64_1.2.700.v20221108-1024/eclipse_11801.so -startup /Users/elecharny/rcp-2022-12/Eclipse.app/Contents/MacOS//../Eclipse/plugins/org.eclipse.equinox.launcher_1.6.400.v20210924-0641.jar --launcher.appendVmargs -product org.eclipse.epp.package.rcp.product -data file:/Users/elecharny/eclipse-workspace-17/ -launcher /Users/elecharny/rcp-2022-12/Eclipse.app/Contents/MacOS/eclipse -product org.eclipse.epp.package.rcp.product -keyring /Users/elecharny/.eclipse_keyring -vm /Users/elecharny/.p2/pool/plugins/org.eclipse.justj.openjdk.hotspot.jre.full.macosx.x86_64_19.0.1.v20221102-1007/jre/lib/libjli.dylib eclipse.home.location=file:/Users/elecharny/rcp-2022-12/Eclipse.app/Contents/Eclipse/ eclipse.launcher=/Users/elecharny/rcp-2022-12/Eclipse.app/Contents/MacOS/eclipse eclipse.launcher.name=Eclipse eclipse.p2.data.area=file:/Users/elecharny/.p2/ eclipse.p2.max.threads=10 eclipse.p2.profile=_Users_elecharny_rcp-2022-12_Eclipse.app_Contents_Eclipse eclipse.product=org.eclipse.epp.package.rcp.product eclipse.startTime=1685138288747 eclipse.stateSaveDelayInterval=30000 eclipse.vm=/Users/elecharny/.p2/pool/plugins/org.eclipse.justj.openjdk.hotspot.jre.full.macosx.x86_64_19.0.1.v20221102-1007/jre/lib/libjli.dylib eclipse.vmargs=-Declipse.p2.max.threads=10 -Doomph.update.url=https://download.eclipse.org/oomph/updates/milestone/latest -Doomph.redirection.index.redirection=index:/->http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/ --add-opens=java.base/java.lang=ALL-UNNAMED -Dosgi.requiredJavaVersion=17 -Dosgi.instance.area.default=@user.home/eclipse-workspace -Dosgi.dataAreaRequiresExplicitInit=true -Dorg.eclipse.swt.graphics.Resource.reportNonDisposed=true -Dsun.java.command=Eclipse -Xms256m -Xmx2048m -XX:+UseG1GC -XX:+UseStringDeduplication --add-modules=ALL-SYSTEM -XstartOnFirstThread -Dorg.eclipse.swt.internal.carbon.smallFonts -Xdock:icon=../Resources/Eclipse.icns -Declipse.p2.max.threads=10 -Doomph.update.url=https://download.eclipse.org/oomph/updates/milestone/latest -Doomph.redirection.index.redirection=index:/->http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/ --add-opens=java.base/java.lang=ALL-UNNAMED -Dosgi.requiredJavaVersion=17 -Dosgi.instance.area.default=@user.home/eclipse-workspace -Dosgi.dataAreaRequiresExplicitInit=true -Dorg.eclipse.swt.graphics.Resource.reportNonDisposed=true -Dsun.java.command=Eclipse -Xms256m -Xmx2048m -XX:+UseG1GC -XX:+UseStringDeduplication --add-modules=ALL-SYSTEM -XstartOnFirstThread -Dorg.eclipse.swt.internal.carbon.smallFonts -Xdock:icon=../Resources/Eclipse.icns -Djava.class.path=/Users/elecharny/rcp-2022-12/Eclipse.app/Contents/MacOS//../Eclipse/plugins/org.eclipse.equinox.launcher_1.6.400.v20210924-0641.jar equinox.init.uuid=true file.encoding=UTF-8 file.separator=/ ftp.nonProxyHosts=local|.local|169.254/16|*.169.254/16 gosh.args=--nointeractive guice.disable.misplaced.annotation.check=true java.class.path=/Users/elecharny/rcp-2022-12/Eclipse.app/Contents/MacOS//../Eclipse/plugins/org.eclipse.equinox.launcher_1.6.400.v20210924-0641.jar java.class.version=63.0 java.home=/Users/elecharny/.p2/pool/plugins/org.eclipse.justj.openjdk.hotspot.jre.full.macosx.x86_64_19.0.1.v20221102-1007/jre java.io.tmpdir=/var/folders/kz/kzvhcwd904b5ww36551nmvtm0000gn/T/ java.library.path=/Users/elecharny/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:. java.runtime.name=OpenJDK Runtime Environment java.runtime.version=19.0.1+10 java.specification.name=Java Platform API Specification java.specification.vendor=Oracle Corporation java.specification.version=19 java.vendor=Eclipse Adoptium java.vendor.url=https://adoptium.net/ java.vendor.url.bug=https://github.com/adoptium/adoptium-support/issues java.vendor.version=Temurin-19.0.1+10 java.version=19.0.1 java.version.date=2022-10-18 java.vm.compressedOopsMode=32-bit java.vm.info=mixed mode java.vm.name=OpenJDK 64-Bit Server VM java.vm.specification.name=Java Virtual Machine Specification java.vm.specification.vendor=Oracle Corporation java.vm.specification.version=19 java.vm.vendor=Eclipse Adoptium java.vm.version=19.0.1+10 jdk.debug=release line.separator= maven.defaultProjectBuilder.disableGlobalModelCache=true native.encoding=UTF-8 oomph.redirection.index.redirection=index:/->http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/ oomph.update.url=https://download.eclipse.org/oomph/updates/milestone/latest org.eclipse.debug.ui.breakpoints.toggleFactoriesUsed=false org.eclipse.debug.ui.debugViewToolbarVisible=false org.eclipse.equinox.launcher.splash.location=/Users/elecharny/.p2/pool/plugins

mickaelistria commented 1 year ago

I would blame some support of Tree in macOS for that, not being able to expand to the right level then. @Phillipus you seem currently very active in mac support, can you please check whether you can reproduce this issue? Feel free to refine title or move the issue to other component if you get a better sense of the cause.

elecharny commented 1 year ago

Possibly. OTOH, it was working fine a few years ago, so something has changed that broke it. Thanks for the follow up!

Phillipus commented 1 year ago

I would blame some support of Tree in macOS for that, not being able to expand to the right level then. @Phillipus you seem currently very active in mac support, can you please check whether you can reproduce this issue? Feel free to refine title or move the issue to other component if you get a better sense of the cause.

A quick test on Intel Mac with 4.27 shows that "Link With Editor" works for me but my setup might be different to the OP's. What are the exact steps to reproduce (Working sets, filters, etc)

elecharny commented 1 year ago

Hi @Phillipus, the projects presentation is hierarchical, top level elements are Working Sets, I'm not using any filter other that those defined by default. image

Phillipus commented 1 year ago

@elecharny I tried with those settings. Still working for me. Maybe a plug-in is interfering? Try with a basic setup (download from here https://download.eclipse.org/eclipse/downloads/drops4/R-4.27-202303020300/) and new workspace.

elecharny commented 1 year ago

Will do that. Here are the plugin I have installed on this instance:

I won't be surprised that Yaml editor was the culprit! Just a blind guess, but it's always a good idea to spit on Yaml anyway ;-)

elecharny commented 1 year ago

My bad. I think I was on the wrong perspective (Debug instead of Java).

All works fine when on the Java perspective!

Sorry for the noise :/

elecharny commented 1 year ago

Wrong perspective, All is working fine when on the Java one.

Phillipus commented 1 year ago

Wrong perspective, All is working fine when on the Java one.

Shouldn't matter. It's working for me in Debug perspective.

mickaelistria commented 1 year ago

Note that I don't think the perspective should matter. The Link with Editor feature is a feature of the Project Explorer view, independently from the perspective.

elecharny commented 1 year ago

You are probably right @mickaelistria. Should I reopen the issue with an additional info about the Debug perspective being used?

LMousseau commented 1 year ago

I've recently starting having this issue of "Link with Editor" only working in Project Explorer if the project / module is already expanded, as well. Similar setup, using Java or Java EE views (the view doesn't seem to matter), and with Projects Presentation set to either "Hierarchical" or "Flat" (doesn't seem to matter), and Top Level Elements set to either "Projects" or "Working Sets" (again... doesn't seem to matter).

After reading the above comments, I figured I'd try playing with the "Filters and Customization...". It appears to me the culprit is PyDev. If I uncheck "PyDev Navigator Content" under the "Filters and Customization" > "Content" tab, "Link with Editor" now works as it's supposed to.

elecharny commented 1 year ago

Hi @LMousseau, a coincidence, probably. I don't have PyDev installed on my setup, and still, the 'link with editor' is not working for me.

jposterloh commented 10 months ago

I have the problem when I set "Working Set" as top-level and "Hierarchical" as Project Presentation. All other combinations work.

eclipse Version: 2023-06 (4.28.0)

My current workaround is to set Project Presantation to "Flat".