search

eclipse-platform / eclipse.platform.ui

Eclipse Platform
https://projects.eclipse.org/projects/eclipse.platform
Eclipse Public License 2.0
79 stars 168 forks source link

sporadic issue : Search results : Incomplete search results are shown #992

Open raghucssit opened 1 year ago

raghucssit commented 1 year ago

Bug type : Sporadic Eclipse version : 2023-09 (4.29) Build id: I20230802-1800 OS : Linux

Steps to reproduce:

  1. Import the attached project. p60.zip
  2. Open File Search then search for text some
  3. Check the search results in Search View. Mostly for the first time results are complete.
  4. Clear All using "Search View" toolbar and hit Refresh next to it. Try this 4-5 times quickly.
  5. It can be reproduced only by clicking Refresh in the Search View tool bar couple of time instantly.
  6. Now observe the results in step 4/5 sometimes some results are missing. Please refer the attached images.

In development environment when I lauch a 'run-time' in debug mode this is very frequent. Even the first time search results are incomplete. search-issue-missing-items search-issue-missing-items-4-6

Below is the screenshot of the first serach result from run-time debug. search-issue-missing-items-run-time-debug

trancexpress commented 1 year ago

Some viewer update problem? I see the total matches count is consistent...

merks commented 1 year ago

I’ve seen this problem too on Windows but it’s hard to reproduce. I thought maybe it was related to multi thread search.

jukzi commented 1 year ago

I thought maybe it was related to multi thread search.

That could be - It's not deterministic which thread handles which file . i'd be happy to help if someone finds the bug. may be somewhere near org.eclipse.search.internal.ui.text.FileSearchQuery.TextSearchResultCollector.endReporting()

nunnrlc commented 8 months ago

I get it frequently on large PHP projects. Possibly the search seems to miss listing hits in files I have open editors for.

If I pull the search results back from the "Show previous searches" history menu at the top right of the search pane, the listing shows correctly (without re-running the search).

I see it reported over here too: https://bugs.eclipse.org/bugs/show_bug.cgi?id=581802 Daniil Terentev there says:

I can add that if you change view from tree to list and then back to tree display of search results becomes correct.

My set up... Version: 2023-12 (4.30.0) Build id: 20231201-2043 Windows 10