eclipse-platform / eclipse.platform

https://eclipse.dev/eclipse/
Eclipse Public License 2.0
74 stars 107 forks source link

Use Jenkins timestamps instead of Maven logger with dateformat #342

Open Bananeweizen opened 1 year ago

Bananeweizen commented 1 year ago

At least the platform build uses Maven logger to show the timing of the build, see grafik That adds the current time in front of each Maven console line.

I would rather like to have the Jenkins timestamps plugin be enabled globally and the logger removed afterwards: https://plugins.jenkins.io/timestamper/ That would have the benefit of showing timestamps for each line of the build (not just Maven), for every project being built on this Jenkins instance, and being able to switch to "runtime" instead of "current time".

However, that would obviously require installation and configuration of the plugin on Jenkins, not only code changes here. What's the right way to trigger (and discuss) that? Should I raise a gitlab issue?

iloveeclipse commented 1 year ago

Should I raise a gitlab issue?

Yes, please, and post here a link.

mickaelistria commented 1 year ago

No need to involve EF infra support; this request is a user configuration task, just adding timestamps to options block of Jenkinsfile like it is already done at https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/Jenkinsfile#L6

Bananeweizen commented 1 year ago

I'm aware this can be done in each pipeline around arbitrary blocks. However, it can also be enabled for all pipelines by default, no matter whether they use that block in their code. And the question then is how to balance between adding value for people who are not even aware of this kind of configuration, and those that see global changes of their own pipelines as an "intrusion". In the past my experience has been that the majority is not aware and therefore would be happy with applying it by default.