search

eclipse-qvtd / org.eclipse.qvtd

Eclipse Public License 2.0
0 stars 0 forks source link

[compiler] Ensure correct EnvironmentFactory #187

Closed eclipse-qvtd-bot closed 16 hours ago

eclipse-qvtd-bot commented 16 hours ago

| --- | --- | | Bugzilla Link | 496116 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Jun 14, 2016 11:15 EDT | | Modified | Jun 15, 2016 06:47 EDT | | Reporter | Ed Willink |

Description

QVTi compilation requires a QVTiEnvironmentFactory and so this is passed to QVTrCompilerChain, but if there are templates a QVTrEnvironmentFactory is needed to avoid a CCE for the wrong TemplateParameterSubstitutionVisitor.

QVTrCompilerChain probably needs a QVTrEnvironmentFactory which should be enforced by QVTr2QVTC, a QVTcEnvironmentFactory and then a QVTiEnvironmentFactory.

eclipse-qvtd-bot commented 16 hours ago

By Ed Willink on Jun 14, 2016 11:41

(In reply to Ed Willink from comment #0)

QVTrCompilerChain probably needs a QVTrEnvironmentFactory which should be enforced by QVTr2QVTC, a QVTcEnvironmentFactory and then a QVTiEnvironmentFactory.

Multiple EnvironmentFactory will be very inefficient. Probably just need a settable 'flavour' so that while processing QVTr, QVTr visitors are constructed etc.

eclipse-qvtd-bot commented 16 hours ago

By Ed Willink on Jun 15, 2016 06:47

(In reply to Ed Willink from comment #1)

Probably just need a settable 'flavour'

QVTbaseEnvironmentFactory has a settable CreateStrategy.