search

eclipse-qvto / org.eclipse.qvto

Eclipse Public License 2.0
0 stars 1 forks source link

Accommodate Bug 431177 command API deprecations #1073

Open eclipse-qvt-oml-bot opened 1 week ago

eclipse-qvt-oml-bot commented 1 week ago

| --- | --- | | Bugzilla Link | 563879 | | Status | NEW | | Importance | P3 normal | | Reported | Jun 03, 2020 06:38 EDT | | Modified | Jul 10, 2020 07:20 EDT | | See also | 431177, Gerrit change 166134 | | Reporter | Ed Willink |

Description

Bug 431177 warns of some upciming deletions. Need to respond.

Fix seems to be just a package change.

eclipse-qvt-oml-bot commented 1 week ago

By Ed Willink on Jun 03, 2020 06:45

Fix seems to be just a package change.

The replacement package seems to be @since 3.1 which was 2005, before QVTo 1.0 in 2008 so I think we can just change as part of the next maintenance release.

eclipse-qvt-oml-bot commented 1 week ago

By Ed Willink on Jun 10, 2020 06:57

(In reply to Ed Willink from comment #1)

Fix seems to be just a package change.

Not so easy, but all the problems seem to be in org.eclipse.m2m.internal.qvt.oml.editor.ui.quickoutline.AbstractInformationControl which was an uncredited rip off from org.eclipse.jdt.internal.ui.text.AbstractInformationControl in 2013. Evolution of the original probably provides all the solutions.

At worst we have a broken Quick Outline is we ever get a pre/post-deprecation mismatch.

eclipse-qvt-oml-bot commented 1 week ago

By Ed Willink on Jun 10, 2020 07:41

(In reply to Ed Willink from comment #2)

AbstractInformationControl which was an uncredited rip off from org.eclipse.jdt.internal.ui.text.AbstractInformationControl in 2013. Evolution of the original probably provides all the solutions.

The original rip off changed some filtering and select functionalities to be QVTo rather than JDT sensible and also may gratuitous chnages of spelling from "fXXXX" to "myXXXX" making comparison different.

The evolution of JDT's AbstractInformationControl seems to involve some minor improvements to exploit smarter Java for loops and to migrate the API. Looks like we just apply all changes by JDT to our rip off.

eclipse-qvt-oml-bot commented 1 week ago

Jul 10, 2020 07:20

New Gerrit change created: https://git.eclipse.org/r/c/mmt/org.eclipse.qvto/+/166134