Unparser tests not executed on build server

[eclipse-qvt-oml-bot]

| --- | --- | | Bugzilla Link | 579824 | | Status | NEW | | Importance | P3 trivial | | Reported | May 03, 2022 08:55 EDT | | Modified | Aug 25, 2022 07:53 EDT | | See also | Gerrit change 193409, Gerrit change 193545, Gerrit change 193546, Gerrit change 195348, Gerrit change 195349 | | Reporter | Christopher Gerking |

Description

The unparser tests developed for bug 377320 are currently not executed during the Tycho builds. Add them to the AllTests suite.

[eclipse-qvt-oml-bot]

May 17, 2022 05:57

New Gerrit change created: https://git.eclipse.org/r/c/mmt/org.eclipse.qvto/+/193409

[eclipse-qvt-oml-bot]

By Christopher Gerking on May 19, 2022 08:42

The Gerrit build succeeded, but now I'm suddenly facing failures on the local Maven build:

runTest[TestData localstrings --> 0/0/0 (org.eclipse.m2m.tests.qvt.oml.TestQvtUnparser) \ Time elapsed: 0.084 s <<< FAILURE!\ junit.framework.AssertionFailedError:

Original and copy expression differ at 1 places\ RangeDifference {CHANGE/RIGHT, Left: (39, 1) Right: (39, 1)}\ ----LEFT: stringSymbol="ТекÑ?Ñ‚"/>\ ----RIGHT: stringSymbol="?????"/>\ at org.eclipse.m2m.tests.qvt.oml.TestQvtUnparser.assertEclipseCompareEquals(TestQvtUnparser.java:552) \ at\ org.eclipse.m2m.tests.qvt.oml.TestQvtUnparser.runTest(TestQvtUnparser.java:530)

The failure could be due to the encoding of the 'Текст' string in localstrings.qvto, but sometimes it also happens with the "_while_261024" case instead of "localstrings" (apparently never with both in the same run).

[eclipse-qvt-oml-bot]

By Ed Willink on May 19, 2022 15:01

Make sure that every (relevant) project is explicitly UNIX+UTF8.

If you have set the workspace to UNIX+UTF8 you might find some project deviates at run-time.

Edit and save every relevant test file to verify that standard editors display correctly.

[eclipse-qvt-oml-bot]

May 20, 2022 09:03

New Gerrit change created: https://git.eclipse.org/r/c/mmt/org.eclipse.qvto/+/193545

[eclipse-qvt-oml-bot]

May 20, 2022 09:03

New Gerrit change created: https://git.eclipse.org/r/c/mmt/org.eclipse.qvto/+/193546

[eclipse-qvt-oml-bot]

By Christopher Gerking on May 20, 2022 09:19

(In reply to Ed Willink from comment #3)

Make sure that every (relevant) project is explicitly UNIX+UTF8.

Thanks, but the problem seems to be that the Maven surefire plugin must be configured explicitly for UTF8: https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working

Interestingly it doesn't seem to make a difference for the Gerrit build, which succeeds with or without the UFT8 config. But it's needed for my local mvn build using the nightly profile.

[eclipse-qvt-oml-bot]

By Ed Willink on Jun 01, 2022 04:11

(In reply to Christopher Gerking from comment #6)

Interestingly it doesn't seem to make a difference for the Gerrit build, which succeeds with or without the UFT8 config. But it's needed for my local mvn build using the nightly profile.

The Gerrit build is on a Linux machine so it has sensible system defaults that Eclipse does not adjust at the system level.

Locally you're presumably on Windows which is crazy at the system level and for which Eclipse's system / workspace level adjustments are also crazy. Whoever wanted Cp1252 as a default? It just seems to be retained as a legacy whose only purpose is to bite us periodically.

[eclipse-qvt-oml-bot]

Aug 25, 2022 07:53

New Gerrit change created: https://git.eclipse.org/r/c/mmt/org.eclipse.qvto/+/195348

[eclipse-qvt-oml-bot]

Aug 25, 2022 07:53

New Gerrit change created: https://git.eclipse.org/r/c/mmt/org.eclipse.qvto/+/195349