search

eclipse-rap / org.eclipse.rap

Eclipse RAP Runtime (Remote Application Platform)
https://www.eclipse.org/rap/
Eclipse Public License 1.0
17 stars 19 forks source link

Fix Grid getColumn calculation when row header is visible #190

Closed kysmith-csg closed 3 weeks ago

kysmith-csg commented 2 months ago

For the Nebula Grid, when the row header is visible, the getColumn calculation didn't account for the additional width, and so the incorrect column was returned. The width is now added to the accumulator and so the correct column is always returned, even when clicking on the very edge of the column.

Matches Nebula's code here: https://github.com/eclipse/nebula/blob/master/widgets/grid/org.eclipse.nebula.widgets.grid/src/org/eclipse/nebula/widgets/grid/Grid.java#L1262-L1268.

eclipse-rap-bot commented 2 months ago

Can one of the admins verify this patch?

mknauer commented 2 months ago

ok to test