Export all packages from org.eclipse.rap.nebula.jface.gridviewer

eclipse-rap / org.eclipse.rap

Eclipse RAP Runtime (Remote Application Platform)

https://www.eclipse.org/rap/

Eclipse Public License 1.0

17 stars 19 forks source link

Export all packages from org.eclipse.rap.nebula.jface.gridviewer #191

Closed kysmith-csg closed 3 weeks ago

kysmith-csg commented 2 months ago

Makes sure all packages (for now, just a single internal one) is exported from org.eclipse.rap.nebula.jface.gridviewer. Marked as x-internal so clients receive warnings when importing them. See upstream Nebula here: https://github.com/eclipse/nebula/blob/master/widgets/grid/org.eclipse.nebula.widgets.grid/META-INF/MANIFEST.MF#L10 (they combined the gridviewer bundle into the grid bundle but the package name is the same).

eclipse-rap-bot commented 2 months ago

Can one of the admins verify this patch?

mknauer commented 2 months ago

ok to test

ifurnadjiev commented 3 weeks ago

Please update the PR to the current state of RAP main branch.

kysmith-csg commented 3 weeks ago

@ifurnadjiev merged

ifurnadjiev commented 3 weeks ago

ok to test

ifurnadjiev commented 3 weeks ago

@kysmith-csg Please rebase your old two commits on RAP main branch and force push the branch. It still shows that the PR can not be merged due to conflicts.

kysmith-csg commented 3 weeks ago

@ifurnadjiev sorry about that, should be all set now.