ShaclSail should not split shapes by their targets

[hmottestad]

Current Behavior

We split shapes by both target and constraint component. We should only split per constraint component because the specification says that we should consider the set of all nodes that match the targets of a shape.

We should also double check what happens if we have multiple target class declarations where a node matches more than one. Do we then produce more than one validation result for that node?

Even though the specification says that we should consider the set of nodes, we can instead consider the bag of nodes and then dedupe validation results instead. However, this might not work correctly for things like sh:or and sh:not. Worth investigating.

Expected Behavior

-

Steps To Reproduce

No response

Version

all

Are you interested in contributing a solution yourself?

Yes

Anything else?

No response

[VladimirAlexiev]

Related to https://github.com/w3c/data-shapes/issues/143 that gives example of the same node selected multiple times as target of the same shape

• discussion at https://lists.w3.org/Archives/Public/public-shacl/2022Jan/.

So it's a tradeoff (pro: distinct union of targets; cons: split targets and process independently):

• cons: parallelizing shape checking speeds up checking
• cons: deduplicating a large set of targets may be expensive
• pro: working on potentially duplicate targets leads to more work