eclipse-rdf4j / rdf4j

Eclipse RDF4J: scalable RDF for Java
https://rdf4j.org/
BSD 3-Clause "New" or "Revised" License
365 stars 163 forks source link

GH-5055 make mapdb3 default for the FedX engine as well #5067

Closed JervenBolleman closed 4 months ago

JervenBolleman commented 4 months ago

GitHub issue resolved: #5055

Briefly describe the changes proposed in this PR:

Also use MapDB3 for FedX

Hand tested that this resolves the reported problem

JervenBolleman commented 4 months ago

I will try regarding the test case. I also want to mark the mapdb1 as deprecated.

On Sat, Jun 29, 2024, 18:48 Håvard M. Ottestad @.***> wrote:

@.**** approved this pull request.

LGTM! Thanks for fixing this.

Any chance you'd like to create a test so that we can increase our test coverage of the workbench?

https://github.com/eclipse-rdf4j/rdf4j/blob/main/e2e/tests/workbench.spec.js

We use Playwright: https://playwright.dev

— Reply to this email directly, view it on GitHub https://github.com/eclipse-rdf4j/rdf4j/pull/5067#pullrequestreview-2149726810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHQYFMLISGJUGYENZ3F3SDZJ3QO5AVCNFSM6AAAAABKDJKSF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBZG4ZDMOBRGA . You are receiving this because you were assigned.Message ID: @.***>