eclipse-scout / scout.rt

https://www.eclipse.org/scout/
Eclipse Public License 2.0
34 stars 39 forks source link

Table: startCellEdit must not fail if row is not rendered or hiding #1220

Open cguglielmo opened 6 days ago

cguglielmo commented 6 days ago

Use case:

Currently, an exception occurs because startCellEdit calls table.$cell() which fails because $row is null.

397551

If startCell is called while the row is still hiding because of the filtering, the exception does not occur immediately. Instead, the popup is positioned incorrectly and an exception occurs as soon as the popup is being repositioned (e.g. when the table is layouted or scrolled).

The rendered check at CellEditorPopup.position is not required to solve this error. It has been added to make it consistent with the super class. And to make it more failsafe because startCellEdit may return a popup that is not rendered.

350207